[SYCL][Bindless Images] Add new test and re-enable bindless_images/sampling_2D_USM_host.cpp for L0 - #22960
[SYCL][Bindless Images] Add new test and re-enable bindless_images/sampling_2D_USM_host.cpp for L0 #22960dyniols wants to merge 3 commits into
bindless_images/sampling_2D_USM_host.cpp for L0 #22960Conversation
There was a problem hiding this comment.
Pull request overview
Adds bindless-image coverage for aligned device USM and re-enables host-USM sampling on Level Zero.
Changes:
- Adds multi-format, multi-pitch 2D device-USM image testing.
- Supplies the custom row pitch through the image descriptor.
- Removes the resolved Level Zero XFAIL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
aligned_alloc_device_2d.cpp |
Tests sampled image fetches from aligned device USM. |
sampling_2D_USM_host.cpp |
Configures row pitch and enables Level Zero testing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Please review. I will take a look why tests are failing on Windows L0 specifically with |
|
The failure with error message happens because current Windows driver on CI runner is I added on windows that certain driver version is required. |
This PR adds new test
sycl/test-e2e/bindless_images/aligned_alloc_device_2d.cppthat tests aligned_alloc_device withaligned row pitches ranging from the minimum supported value to 8× that value. It also re-enables
bindless_images/sampling_2D_USM_host.cppon L0 and updates its image descriptor to supply the calculated row pitch.