[SYCL] VS2026 fix needs guard in complex - #22994
Open
cperkinsintel wants to merge 2 commits into
Open
Conversation
cperkinsintel
requested review from
KseniyaTikhomirova
and
a lite review from Copilot
August 21, 2026 22:25
Contributor
Author
|
ping @KseniyaTikhomirova |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes MSVC host-compilation failures in the experimental SYCL complex extension by guarding the inline-visibility macro so cl.exe doesn’t see GCC-style __attribute__, and adds a Windows host-compiler regression test to ensure the complex<T> specialization parses under cl.exe.
Changes:
- Add
_MSC_VER(non-Clang) guard for_SYCL_EXT_CPLX_INLINE_VISIBILITY, using__forceinlinefor MSVC. - Add a new compile-only Windows regression test that instantiates
sycl::ext::oneapi::experimental::complex<T>with-fsycl-host-compiler=cl.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sycl/test/extensions/complex/complex_host_compile_win.cpp | New regression test compiling with cl.exe as the SYCL host compiler. |
| sycl/include/sycl/ext/oneapi/experimental/complex/detail/common.hpp | Guard _SYCL_EXT_CPLX_INLINE_VISIBILITY for MSVC (non-Clang) to avoid __attribute__ parsing errors in cl.exe. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+9
to
+10
| // RUN: %clangxx -fsycl -fsycl-host-compiler=cl -fsycl-host-compiler-options='/std:c++20 /MD /EHsc /permissive- /DSYCL_DISABLE_FSYCL_SYCLHPP_WARNING' %s -c -o %t.o | ||
| // UNSUPPORTED: linux |
KseniyaTikhomirova
approved these changes
Aug 27, 2026
KseniyaTikhomirova
left a comment
KseniyaTikhomirova
left a comment
Contributor
There was a problem hiding this comment.
LGTM,
nit: BTW, I do agree with Copilot review, win requirement looks more meaningful than disabling on linux.
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test added