Fix conversation model assignee ID types to match API responses#453
Open
VarshSuresh wants to merge 1 commit intomainfrom
Open
Fix conversation model assignee ID types to match API responses#453VarshSuresh wants to merge 1 commit intomainfrom
VarshSuresh wants to merge 1 commit intomainfrom
Conversation
Updated team_assignee_id to integer type, removed nullable: true, changed descriptions from "return null" to "return 0", fixed search table types from String to Integer, and added alternating integer/zero example values in response examples — all scoped to the conversation model across every version (2.7 through Preview). Ticket model is intentionally unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Towards Dev Rel PQ
The conversations API (GET /:id, GET /all, POST /search) returns
admin_assignee_idandteam_assignee_idas integers, returning0when unassigned. However, the docs hadteam_assignee_idtyped asstring, both fields marked asnullable, descriptions referencingnull, and search tables listing both asString. The tickets API correctly returns these as strings and its docs are accurate, this PR consolidates the conversation model to match the actual API behavior.How?
team_assignee_idtointegertypenullable: trueStringtoInteger, andImplementation Plan
Plan: Fix
admin_assignee_idandteam_assignee_idtypes in conversation modelContext
The real Intercom API returns
admin_assignee_idandteam_assignee_idas integers in conversation responses. The docs have these typed incorrectly as strings in several places. Scope: Conversations model only — ticket model stays unchanged.@2.7–@Preview (OpenAPI YAML files)
Schema type fix:
team_assignee_idin conversation schemasEach version has TWO conversation schemas (
conversation_list_itemandconversation). Change in both:type: string→type: integerexample: '5017691'→example: 5017691Search conversation doc tables (inline in YAML)
Change both
admin_assignee_idandteam_assignee_idfromStringtoIntegerin the conversation search table only (NOT the ticket search table).Response examples updated with alternating integer/zero values
What NOT to change
admin_assignee_idandteam_assignee_idare correctlystringin ticketsString'0'are correctMirrors intercom/developer-docs#842.
Generated with Claude Code