docs: Add multiuser documentation and reposition Workflows#9099
docs: Add multiuser documentation and reposition Workflows#9099
Conversation
joshistoast
left a comment
There was a problem hiding this comment.
Good overall add, but needs some updates.
Notes:
-
I added some quick suggestions for reordering to keep the non subgrouped docs links at the top of the respective parent group.
-
Lots of areas where the
<Steps>component can be used for those instructional step-by-step ordered lists. -
I think we should move the spec to the corresponding invoke dir as a feature readme, as opposed to being a docs page.
-
Found a couple broken links and left the fix suggestions.
-
The multi user docs leaves a lot of "not right now, but in the future for sure" promises, maybe it'd be better to just say "Not at this time, create an issue if this is important to you" verbiage?
-
There seemed to be an instance or two of inconsistency between existence of a feature. For example the user vs administrative docs seem to have different opinions on the existence of a user management webui. And there is also documentation now of a board having a desciption- which unless I'm mistaken doesn't exist.
-
I can have my LLM do another pass over this to see if I missed anything, but this was everything I found initially.
Co-authored-by: Josh Corbett <joshwcorbett@icloud.com>
Co-authored-by: Josh Corbett <joshwcorbett@icloud.com>
|
Thanks for the thorough review. There was a lot more cruft in the docs than I realized. I've implemented all the suggested changes and removed redundant and out-of-date content. Let me know if I missed anything. |
joshistoast
left a comment
There was a problem hiding this comment.
PR remains inconsistent with real behavior. Features that don't exist, incorrect endpoints, inaccurate and conflicting feature behaviors, etc.
Also we should document GET /api/v1/auth/status
| **User Management:** | ||
|
|
||
| ```python | ||
| GET /api/v1/users # List users (admin only) |
There was a problem hiding this comment.
These all should begin with /api/v1/auth/users
| **Model Management (Write Operations):** | ||
|
|
||
| ```python | ||
| POST /api/v1/models/install # Install model (admin only) |
There was a problem hiding this comment.
These are all /api/v2/models
| **Model Management (Read Operations):** | ||
|
|
||
| ```python | ||
| GET /api/v1/models/ # List models (all users) |
|
|
||
| #### Change Password | ||
|
|
||
| **Endpoint:** `POST /api/v1/auth/change-password` |
|
|
||
| #### List Users | ||
|
|
||
| **Endpoint:** `GET /api/v1/users` |
There was a problem hiding this comment.
| **Endpoint:** `GET /api/v1/users` | |
| **Endpoint:** `GET /api/v1/auth/users` |
| 4. Cancel stuck or problematic tasks | ||
| </Steps> | ||
|
|
||
| **User Statistics:** |
There was a problem hiding this comment.
Can't find this feature
There was a problem hiding this comment.
Yeah, never got implemented, like a number of other nice to have features. Removed.
| - Full model management (add, delete, configure models) | ||
| - Create and manage user accounts | ||
| - View and manage all users' generation queues | ||
| - View and manage all users' boards, images, and workflows (including system-owned legacy content) |
There was a problem hiding this comment.
| - View and manage all users' boards, images, and workflows (including system-owned legacy content) | |
| - View and manage all users' boards, images, and workflows |
|
|
||
| **Response:** | ||
|
|
||
| ```json |
There was a problem hiding this comment.
Returns a plain array, no pagination
| "display_name": "John Doe", | ||
| "is_admin": false, | ||
| "is_active": true, | ||
| "created_at": "2024-01-15T10:00:00Z", |
There was a problem hiding this comment.
Add updated_at field below here
|
|
||
| **Firewall Rules:** | ||
|
|
||
| It is best to restrict access to trusted networks and remote IP addresses, or use a VPN to connect to your home network. Rate limit connections to InvokeAI's authentication endpoint `http://your.host:9090/login`. |
There was a problem hiding this comment.
Login endpoint is /api/v1/auth/login
Co-authored-by: Josh Corbett <joshwcorbett@icloud.com>
Summary
This PR migrates the multiuser documentation from
docs-oldinto the new astrodocsdirectory. It also moves the Workflows section into Features, which seems to be a more appropriate place for it than at the top level.For convenience, this PR also updates the
make docsMakefile target.Related Issues / Discussions
QA Instructions
make docswill fire up astroFeaturessection.Merge Plan
Simple merge.
Checklist
What's Newcopy (if doing a release after this PR)