feat(ui): add Generate tab Upscale controls#9126
feat(ui): add Generate tab Upscale controls#9126AsuraAce wants to merge 10 commits intoinvoke-ai:mainfrom
Conversation
|
I found one more support-scope issue while smoke testing: latent Upscale is currently exposed for non-SD model families like ANIMA. I’m moving this back to draft briefly to tighten supported model gating before review. |
|
I quite like the idea of this feature, my one feedback would be to update your hover tooltips for each control to be more meaningful. Eg: What is a refinement LoRA? And for the sliders, maybe along the lines of what a higher value for that setting will do versus a lower value. |
|
@kappacommit Thanks for the feedback, tooltips are updated, i hope things are clearer now. |
…ale-hrf-pr # Conflicts: # invokeai/frontend/web/src/features/controlLayers/store/paramsSlice.test.ts # invokeai/frontend/web/src/features/controlLayers/store/paramsSlice.ts # invokeai/frontend/web/src/features/controlLayers/store/types.ts
Much better, thank you |
|
While on the surface this is a great thing to have, we have a dedicated upscale tab. This is now effectively duplicating the upscale feature, and I feel like we should focus on instead improving that |
This is actually what it try to improve. Instead of user having to do something like: Generate Tab (Generate Image) > Upscale Tab (Upscale Image) > Canvas (Add Detail). This takes minutes and you loose metadata in the process. Adding Upscale and Detailer to the Generate Tab would make this more convenient and faster to generate images while not taking anything away. |
Summary
This PR adds Generate-tab Upscale controls backed by the existing High Resolution Fix graph path.
It includes:
Upscaleaccordion with Latent and Upscale Model methodsThe main user impact is that Generate users can configure an upscale/refinement pass directly from the Generate tab, then recall/remix images using the original base generation dimensions plus the saved Upscale settings.
View screenshots
Related Issues / Discussions
N/A
QA Instructions
Manual reviewer QA:
Image,Generation,Upscale,Refiner,Advanced.UpscalewithEnableoff and confirm the settings are visible but muted/disabled.Denoise Strength,Tile Control,Tile Control Weight, andRefinement LoRAs; confirm the help text is specific to Upscale/refinement behavior.Latent, set Scale to2, and generate. Confirm generation completes and the output dimensions match the scaled size.Upscale Model, select an upscale model and a Tile/Union ControlNet model, then generate successfully.Refinement Model, setRefinement LoRAstoDedicated, add a LoRA, and generate.Recall Parameters; confirm Upscale fields are listed, including the refinement model and dedicated refinement LoRAs when used.Automated checks run locally:
pnpm --dir invokeai/frontend/web exec vitest run src/features/nodes/util/graph/generation/addHighResFix.test.ts src/features/gallery/components/ImageMetadataViewer/ImageMetadataActions.test.tsx src/features/metadata/parsing.test.ts src/features/metadata/parsing.test.tsx src/features/controlLayers/store/paramsSlice.test.ts src/features/queue/store/readiness.test.ts pnpm run --dir invokeai/frontend/web lint:tsc pnpm run --dir invokeai/frontend/web lint:eslint pnpm run --dir invokeai/frontend/web lint:prettier git diff --checkAdditional local smoke coverage:
Merge Plan
No special merge sequencing is required. This touches persisted Generate params and includes the corresponding migration/test coverage.
Checklist
What's Newcopy (not applicable)