fix(ios): prevent Cordova package generation race condition#8360
Open
MOHITKOURAV01 wants to merge 1 commit intoionic-team:mainfrom
Open
fix(ios): prevent Cordova package generation race condition#8360MOHITKOURAV01 wants to merge 1 commit intoionic-team:mainfrom
MOHITKOURAV01 wants to merge 1 commit intoionic-team:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported in #8251 where the CLI does not wait for Cordova package
.swiftand.podspecfiles to finish generating before continuing the update flow.The package manager checks were addressed in #8321, and this PR addresses the remaining race condition.
Changes:
generateCordovaPackageFileinsidegenerateCordovaPackageFiles.generateCordovaPodspecinsidegenerateCordovaPodspecs.Fixes #8251