feat(item-option): add inner and container parts#30929
Open
brandyscarney wants to merge 2 commits intofeature-8.8from
Open
feat(item-option): add inner and container parts#30929brandyscarney wants to merge 2 commits intofeature-8.8from
brandyscarney wants to merge 2 commits intofeature-8.8from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
changed the title
ShaneK
approved these changes
Feb 27, 2026
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looks good! Just a couple nits
| */ | ||
| configs({ directions: ['ltr'], modes: ['md'] }).forEach(({ title, config }) => { | ||
| test.describe(title('item-option: custom'), () => { | ||
| test.describe(title('CSS shadow parts'), () => { |
Member
There was a problem hiding this comment.
Suggested change
| test.describe(title('CSS shadow parts'), () => { | |
| test.describe('CSS shadow parts', () => { |
Nit: The title method just appends mode/direction or mode/direction/palette to the string. In this case, it's redundant to use it in nested describes like this, and usually when we have nested describes we don't use it twice.
| * @slot end - Content is placed to the right of the option text in LTR, and to the left in RTL. | ||
| * | ||
| * @part native - The native HTML button or anchor element that wraps all child elements. | ||
| * @part inner - The inner container element that wraps the option content. |
Member
There was a problem hiding this comment.
Suggested change
| * @part inner - The inner container element that wraps the option content. | |
| * @part inner - The inner wrapper element that arranges the option content. |
Nit: Avoid confusing terminology since container is a part
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The inner structural elements of item-option are not exposed as shadow parts, preventing users from being able to customize their styles directly.
What is the new behavior?
innerandcontainershadow partsDoes this introduce a breaking change?