fix(tab-button): match height to tab-bar in ionic-md style#31209
Draft
OS-jacobbell wants to merge 6 commits into
Draft
fix(tab-button): match height to tab-bar in ionic-md style#31209OS-jacobbell wants to merge 6 commits into
OS-jacobbell wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Tab buttons in the ionic-md theme are slightly shorter than the tab bar. This is inconsistent when dev tools are in use in firefox, causing screenshot tests to fail.
What is the new behavior?
Does this introduce a breaking change?
Other information
The
line-heightstyle ofglobals.typographyseems to be causing the issue. The tab bar content height is 48px while the buttons occupy 44px with line-height specified. Removing it makes the tab buttons occupy all 48px.