Repository navigation
fix(radio-group): support compareWith in deselection, tabindex and handle null values safely - #31590
Open
rudrakshagarwal4200-ai wants to merge 3 commits into
Conversation
Enhance comparison logic to handle undefined and null values.
Refactor radio selection logic to use isOptionSelected for better comparison.
Added tests for radio group deselection and null handling.
|
@rudrakshagarwal4200-ai is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
compareWithwith property name or custom function onion-radio-group:nullas the current value threw a TypeError (Cannot read properties of null) incompareOptionswhen accessingcurrentValue[compareWith].radio-group.tsx,onClickandonKeydowncheckednewValue !== currentValueusing strict reference equality, preventingallowEmptySelectionfrom deselecting an option when values matched bycompareWithbut were distinct object instances.setRadioTabindexused strict reference equality (radio.value === value) instead ofisOptionSelected(value, radio.value, this.compareWith), causing incorrect roving tabindex focus for object values.This PR fixes these issues by:
null/undefinedvalues incompareOptionsand returningfalseearly inisOptionSelectedwhencurrentValueisnullorundefined.isOptionSelectedinonClickandonKeydownto properly supportallowEmptySelectiondeselection withcompareWith.isOptionSelectedinsetRadioTabindexto find the checked radio button.core/src/components/radio-group/test/radio-group.spec.tsx.Fixes #30560