Skip to content

ensure http response body is closed#1103

Merged
gammazero merged 3 commits intomainfrom
close-http-resp-body
Feb 10, 2026
Merged

ensure http response body is closed#1103
gammazero merged 3 commits intomainfrom
close-http-resp-body

Conversation

@gammazero
Copy link
Copy Markdown
Contributor

When appropriate, consume all body data before close to allow connection reuse.

When appropriate, consume all body data before close to allow connection reuse.
@gammazero gammazero requested review from a team and lidel as code owners February 7, 2026 10:45
@gammazero gammazero changed the title Ensure http response body is closed ensure http response body is closed Feb 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.71%. Comparing base (77bd614) to head (6baa985).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
filestore/fsrefstore.go 0.00% 4 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
+ Coverage   61.67%   61.71%   +0.03%     
==========================================
  Files         265      265              
  Lines       26528    26523       -5     
==========================================
+ Hits        16362    16368       +6     
+ Misses       8481     8470      -11     
  Partials     1685     1685              
Files with missing lines Coverage Δ
bitswap/network/httpnet/httpnet.go 59.17% <100.00%> (+0.10%) ⬆️
gateway/backend_car_fetcher.go 80.51% <100.00%> (-0.50%) ⬇️
routing/http/client/client.go 75.53% <100.00%> (+0.06%) ⬆️
filestore/fsrefstore.go 46.10% <0.00%> (ø)

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread bitswap/network/httpnet/httpnet.go Outdated
@gammazero gammazero merged commit 6aa643a into main Feb 10, 2026
17 checks passed
@gammazero gammazero deleted the close-http-resp-body branch February 10, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants