Open
Conversation
hardikdr
added
the
area/metal-automation
nikatza
force-pushed
the
cable-checker
branch
2 times, most recently
from
0d3b709 to
e06b196
Compare
nikatza
force-pushed
the
cable-checker
branch
from
e06b196 to
fdf5acc
Compare
nikatza
force-pushed
the
cable-checker
branch
from
fdf5acc to
c31e40e
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Comment on lines
+321
to
+330
| // only cisco/nx for the moment | ||
| if gvk == nxv1alpha1.GroupVersion.WithKind("LLDPConfig") { | ||
| lc := new(nxv1alpha1.LLDPConfig) | ||
| if err := s.ProviderConfig.Into(lc); err != nil { | ||
| return reconcile.TerminalError(fmt.Errorf("failed to parse provider config into LLDPConfig: %w", err)) | ||
| } | ||
| if err := r.validateProviderConfigNXOS(ctx, lc, s); err != nil { | ||
| return reconcile.TerminalError(fmt.Errorf("configuration error in provider config ref %w", err)) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
With this we are leaking the Cisco NX-OS specific implementation into the core and thus break our provider pattern, where usually the core would not contain anything that is specific to one platform..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
LLDPconfiguration for Cisco devices. Notice that OpenConfig and Cisco models deviate from each other, and thus the provider-agnostic resource is reduced to a minimum set of properties.OpenConfig model
Cisco DME LLDP Instance
Cisco DME LLDP per-interface configuration