-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
#2460: Fix getBoolean(GLExt.GL_FRAMEBUFFER_SRGB_CAPABLE_EXT) causes error 1280 (invalid enum) #2461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2460: Fix getBoolean(GLExt.GL_FRAMEBUFFER_SRGB_CAPABLE_EXT) causes error 1280 (invalid enum) #2461
Conversation
|
GL_FRAMEBUFFER_SRGB_CAPABLE_EXT is actually queryable via glGetBooleanv, but it is provided by the EXT_framebuffer_sRGB extension. I suspect that some drivers that provided opengl3+ capabilities, do not implement a fallback for this extension. |
riccardobl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this check is only used for debugging purposes and, as noted, it is not reliable across different platforms, i am ok with removing it.
But this PR needs to be cleaned from the unrelated formatting and logging changes, can you do that?
Thanks
jme3-core/src/main/java/com/jme3/renderer/opengl/GLRenderer.java
Outdated
Show resolved
Hide resolved
Done |
riccardobl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you
GL_FRAMEBUFFER_SRGB_CAPABLE_EXTis likely not a queryable state viaglGetBooleanv. It's a capability flag for configuring framebuffers, not for querying the global sRGB state. It's good that it's commented out.This PR should fix #1996