Skip to content

Conversation

@capdevon
Copy link
Contributor

@capdevon capdevon commented May 27, 2025

GL_FRAMEBUFFER_SRGB_CAPABLE_EXT is likely not a queryable state via glGetBooleanv. It's a capability flag for configuring framebuffers, not for querying the global sRGB state. It's good that it's commented out.

This PR should fix #1996

@yaRnMcDonuts yaRnMcDonuts added this to the v3.9.0 milestone May 28, 2025
@yaRnMcDonuts yaRnMcDonuts modified the milestones: v3.9.0, v3.10.0 Dec 30, 2025
@riccardobl
Copy link
Member

riccardobl commented Jan 14, 2026

GL_FRAMEBUFFER_SRGB_CAPABLE_EXT is actually queryable via glGetBooleanv, but it is provided by the EXT_framebuffer_sRGB extension.

I suspect that some drivers that provided opengl3+ capabilities, do not implement a fallback for this extension.

Copy link
Member

@riccardobl riccardobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this check is only used for debugging purposes and, as noted, it is not reliable across different platforms, i am ok with removing it.
But this PR needs to be cleaned from the unrelated formatting and logging changes, can you do that?

Thanks

@riccardobl riccardobl self-assigned this Jan 14, 2026
@capdevon
Copy link
Contributor Author

Since this check is only used for debugging purposes and, as noted, it is not reliable across different platforms, i am ok with removing it. But this PR needs to be cleaned from the unrelated formatting and logging changes, can you do that?

Thanks

Done

Copy link
Member

@riccardobl riccardobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you

@riccardobl riccardobl added the defect Something that is supposed to work, but doesn't. Less severe than a "bug" label Jan 17, 2026
@riccardobl riccardobl merged commit 77fdf95 into jMonkeyEngine:master Jan 17, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

defect Something that is supposed to work, but doesn't. Less severe than a "bug"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setGraphicsDebug leads to GL_INVALID_ENUM

3 participants