Fixed bug where images that had been updated on the server would not be downloaded.#30
Open
antoinerabanes wants to merge 13 commits intojakemarsh:masterfrom
Open
Fixed bug where images that had been updated on the server would not be downloaded.#30antoinerabanes wants to merge 13 commits intojakemarsh:masterfrom
antoinerabanes wants to merge 13 commits intojakemarsh:masterfrom
Conversation
…request to add if-unmodified-since header field to the request
Contributor
Author
|
jake? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jake,
I encountered a bug using your lovely lib where once an image had been downloaded it would be cached and never re-downloaded even if the image has been modified on the server.
I now send a request for the image with an http 304 if-unmodified-since with the date of the last successful download of the image.
Then the image gets downloaded only if it has been modified on the server.