Skip to content

Provide a working location for famfamfam flags#3722

Open
pljones wants to merge 1 commit into
jamulussoftware:mainfrom
pljones:fixes-3715/alternative-location-for-famfamfam-flags
Open

Provide a working location for famfamfam flags#3722
pljones wants to merge 1 commit into
jamulussoftware:mainfrom
pljones:fixes-3715/alternative-location-for-famfamfam-flags

Conversation

@pljones
Copy link
Copy Markdown
Collaborator

@pljones pljones commented Jun 2, 2026

Short description of changes

Provides a working location for famfamfam flags, as agreed in #3715

CHANGELOG: Bugfix: Provide a working location for famfamfam flags

Context: Fixes an issue?

Fixes 3715

Does this change need documentation? What needs to be documented and how?

Yes. Here's the English forms of the update:

./Jamulus --version -- TRANSLATED

$ ./Jamulus --version
 *** Jamulus, Version 3.12.1dev-57f439f8-dirty
 *** Internet Jam Session Software
 *** Released under the GNU General Public License version 2 or later (GPLv2)
 *** <https://www.gnu.org/licenses/old-licenses/gpl-2.0.html>
 ***
 *** This program is free software; you can redistribute it and/or modify it under
 *** the terms of the GNU General Public License as published by the Free Software
 *** Foundation; either version 2 of the License, or (at your option) any later version.
 *** There is NO WARRANTY, to the extent permitted by law.
 ***
 *** This app uses the following libraries, resources or code snippets:
 ***
 *** Qt cross-platform application framework 6.11.1 (build), 6.11.1 (runtime)
 *** <https://www.qt.io>
 ***
 *** Opus Interactive Audio Codec
 *** <https://www.opus-codec.org>
 ***
 *** Audio reverberation code by Perry R. Cook and Gary P. Scavone, 1995 - 2021, The Synthesis ToolKit in C++ (STK)
 *** <https://ccrma.stanford.edu/software/stk>
 ***
 *** Some pixmaps are from the  Open Clip Art Library (OCAL)
 *** <https://openclipart.org>
 ***
 *** Flag icons by Mark James
 *** https://www.iconarchive.com/artist/famfamfam.html (originally www.famfamfam.com)
 ***
 *** Some sound samples are from Freesound
 *** <https://freesound.org>
 ***
 *** Copyright © 2005-2026 The Jamulus Development Team

Help->About->Acknowledgements -- TRANSLATED

image

README.md -- NOT TRANSLATED

Acknowledgements

Jamulus contains code from different sources (see also COPYING). The developers wish
to thank the maintainers of these projects for making their efforts available to us under their respective licences:

src/res/flags/readme.txt -- NOT TRANSLATED

*The original site is no longer available.*  We are directing people to https://www.iconarchive.com/artist/famfamfam.html

Flag icons - http://www.famfamfam.com

These icons are public domain, and as such are free for any use (attribution appreciated but not required).

Note that these flags are named using the ISO3166-1 alpha-2 country codes where appropriate. A list of codes can be found at http://en.wikipedia.org/wiki/ISO_3166-1_alpha-2

If you find these icons useful, please donate via paypal to mjames@gmail.com (or click the donate button available at http://www.famfamfam.com/lab/icons/silk)

Contact: mjames@gmail.com

Status of this Pull Request

Review of wording.

What is missing until this pull request can be merged?

Approval of wording.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@pljones pljones added this to the Release 4.0.0 milestone Jun 2, 2026
@pljones pljones self-assigned this Jun 2, 2026
@pljones pljones added the bug Something isn't working label Jun 2, 2026
@pljones pljones added this to Tracking Jun 2, 2026
@github-project-automation github-project-automation Bot moved this to Triage in Tracking Jun 2, 2026
@pljones pljones force-pushed the fixes-3715/alternative-location-for-famfamfam-flags branch from 5fae972 to 72b7883 Compare June 2, 2026 18:47
@pljones pljones moved this from Triage to Waiting on Team in Tracking Jun 2, 2026
Copy link
Copy Markdown
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok - but didn't test it

@pljones pljones requested a review from corrados June 2, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Waiting on Team

Development

Successfully merging this pull request may close these issues.

famfamfam.com link on the Jamulus Github main page does not work anymore

2 participants