Make chat dialog show up as fullscreen on iOS#3830
Open
mcfnord wants to merge 1 commit into
Open
Conversation
The chat dialog overflowed the screen on iOS because it never set Qt::WindowMaximized, unlike the connect dialog and about dialog which were fixed for the same symptom in jamulussoftware#3343 (commit 40e5af1). This applies the identical, already-merged pattern to the third and last affected dialog. Fixes jamulussoftware#3383 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
📡 STAND BY FOR AN LLM-AUTHORED MESSAGE.
Fixes #3383.
The chat dialog overflows the screen on iOS because it never sets
Qt::WindowMaximized. #3343 (commit 40e5af1, "Make connect dialog show up as fullscreen on iOS") fixed the identical symptom by addingto the connect dialog (
connectdlg.cpp) and the about dialog (util.cpp) — but the chat dialog, the third dialog with the same problem, was never given the same treatment. This applies that same, already-merged pattern toCChatDlg, verbatim.Scope: one hunk, iOS/Android only (the block preprocesses out on every other platform, so desktop builds are unaffected). No behavior change anywhere except making the chat window open maximized on mobile, exactly as the connect and about dialogs already do.
Testing note, stated plainly: I could not exercise the changed line myself — it lives inside
#if defined( ANDROID ) || defined( Q_OS_IOS ), so it compiles out on the Linux/desktop toolchain I have. Its correctness rests on being identical to the two instances already shipping (connectdlg.cpp,util.cpp), and onsetWindowState()being aQWidgetmethodCChatDlginherits just asCConnectDlgandCAboutDlgdo. A confirmation on real iOS hardware would be welcome before merge.