bugfix: rollback shared prefix blocks on allocate failure.#1146
Merged
RobbieLeung merged 2 commits intojd-opensource:mainfrom Apr 5, 2026
Merged
bugfix: rollback shared prefix blocks on allocate failure.#1146RobbieLeung merged 2 commits intojd-opensource:mainfrom
RobbieLeung merged 2 commits intojd-opensource:mainfrom
Conversation
RobbieLeung
requested review from
DongheJin,
JimHsiung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
XuZhang99
previously approved these changes
Mar 31, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces rollback logic in BlockManagerPool::allocate to handle allocation failures by releasing shared prefix blocks and embedding IDs. It also adds a unit test to verify this functionality. Review feedback highlights a resource leak caused by the incorrect ordering of reset operations and a memory leak in the test suite resulting from the use of release() instead of reset().
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
XuZhang99
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.