Skip to content

bugfix: fix DeepSeek-3.2 failures when ACL Graph is enabled.#1172

Merged
DongheJin merged 1 commit intojd-opensource:mainfrom
DongheJin:bugfix/ds32_graph
Apr 8, 2026
Merged

bugfix: fix DeepSeek-3.2 failures when ACL Graph is enabled.#1172
DongheJin merged 1 commit intojd-opensource:mainfrom
DongheJin:bugfix/ds32_graph

Conversation

@DongheJin
Copy link
Copy Markdown
Collaborator

No description provided.

XuZhang99
XuZhang99 previously approved these changes Apr 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the third_party/xllm_atb_layers subproject, changes the communication backend from lccl to hccl in mapping_npu.cpp, and introduces conditional logic for enabling the async tiling copy stream in model_context.cpp. Feedback was provided regarding a style guide violation for include paths and a potential performance regression caused by the new environment variable check.

Comment thread xllm/core/framework/model_context.cpp
Comment thread xllm/core/framework/model_context.cpp Outdated
@XuZhang99 XuZhang99 changed the title fix DeepSeek-3.2 failures when ACL Graph is enabled. bugfix: fix DeepSeek-3.2 failures when ACL Graph is enabled. Apr 3, 2026
yq33victor
yq33victor previously approved these changes Apr 3, 2026
Copy link
Copy Markdown
Collaborator

@yq33victor yq33victor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DongheJin DongheJin dismissed stale reviews from yq33victor and XuZhang99 via b80113a April 3, 2026 10:11
@DongheJin DongheJin force-pushed the bugfix/ds32_graph branch from 45df6fa to b80113a Compare April 3, 2026 10:11
@DongheJin DongheJin merged commit fb683db into jd-opensource:main Apr 8, 2026
15 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants