bugfix: fix DeepSeek-3.2 failures when ACL Graph is enabled.#1172
Merged
DongheJin merged 1 commit intojd-opensource:mainfrom Apr 8, 2026
Merged
bugfix: fix DeepSeek-3.2 failures when ACL Graph is enabled.#1172DongheJin merged 1 commit intojd-opensource:mainfrom
DongheJin merged 1 commit intojd-opensource:mainfrom
Conversation
XuZhang99
previously approved these changes
Apr 3, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the third_party/xllm_atb_layers subproject, changes the communication backend from lccl to hccl in mapping_npu.cpp, and introduces conditional logic for enabling the async tiling copy stream in model_context.cpp. Feedback was provided regarding a style guide violation for include paths and a potential performance regression caused by the new environment variable check.
45df6fa to
b80113a
Compare
RobbieLeung
approved these changes
Apr 8, 2026
JimHsiung
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.