Skip to content

bugfix: fix DeepSeek-3.2 failures when ACL Graph is enabled.#1173

Merged
DongheJin merged 1 commit intojd-opensource:release/v0.9.0from
DongheJin:bugfix/ds32_graph_090
Apr 7, 2026
Merged

bugfix: fix DeepSeek-3.2 failures when ACL Graph is enabled.#1173
DongheJin merged 1 commit intojd-opensource:release/v0.9.0from
DongheJin:bugfix/ds32_graph_090

Conversation

@DongheJin
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the xllm_atb_layers subproject, switches the NPU mapping backend from lccl to hccl, and implements conditional logic for asynchronous tiling copy streams in ModelContext based on environment variables and global flags. Feedback was provided to correct an include path in model_context.cpp to ensure it follows the project-root-relative style guide.

Comment thread xllm/core/framework/model_context.cpp
@DongheJin DongheJin changed the title Bugfix/ds32 graph 090 fix DeepSeek-3.2 failures when ACL Graph is enabled. Apr 3, 2026
@DongheJin DongheJin changed the title fix DeepSeek-3.2 failures when ACL Graph is enabled. bugfix: fix DeepSeek-3.2 failures when ACL Graph is enabled. Apr 3, 2026
Comment thread xllm/core/framework/model_context.cpp Outdated

namespace {

bool is_env_enabled(const char* env_name) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to util

@DongheJin DongheJin force-pushed the bugfix/ds32_graph_090 branch from 4bd8527 to 9ec6389 Compare April 3, 2026 10:10
Copy link
Copy Markdown
Collaborator

@yq33victor yq33victor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DongheJin DongheJin force-pushed the bugfix/ds32_graph_090 branch from 9ec6389 to 1168000 Compare April 7, 2026 02:44
@DongheJin DongheJin merged commit dfdd173 into jd-opensource:release/v0.9.0 Apr 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants