refactor: Comprehensive API refactoring and type improvements#3645
Open
jdalrymple wants to merge 6 commits intomainfrom
Open
refactor: Comprehensive API refactoring and type improvements#3645jdalrymple wants to merge 6 commits intomainfrom
jdalrymple wants to merge 6 commits intomainfrom
Conversation
35dbb0a to
5fa0bf5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3645 +/- ##
==========================================
- Coverage 83.12% 82.58% -0.55%
==========================================
Files 234 3 -231
Lines 2578 155 -2423
Branches 273 28 -245
==========================================
- Hits 2143 128 -2015
+ Misses 393 14 -379
+ Partials 42 13 -29
|
Owner
Author
|
Back on this, haha doing it well is a pain 🫠 |
3cd3b5d to
47f50d5
Compare
7f36469 to
389f039
Compare
Bundle ReportChanges will increase total bundle size by 160.8kB (10.26%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: restAssets Changed:
view changes for bundle: requester-utilsAssets Changed:
view changes for bundle: coreAssets Changed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a complete rework of the entire library, making the calls to the various request helpers more explicit to support a wider ranger of flows such as the one where we need to pass raw data to a caller without assuming its structure. Additionally, this simplifies other types of body's we were sending, such as FormData 🙌
Additional fixes:
shareandunshareoperations #3829)fixes #3580, #3807, #3829