Skip to content

refactor: Comprehensive API refactoring and type improvements#3645

Open
jdalrymple wants to merge 6 commits intomainfrom
bug/3580
Open

refactor: Comprehensive API refactoring and type improvements#3645
jdalrymple wants to merge 6 commits intomainfrom
bug/3580

Conversation

@jdalrymple
Copy link
Copy Markdown
Owner

@jdalrymple jdalrymple commented Oct 20, 2024

Summary

This is a complete rework of the entire library, making the calls to the various request helpers more explicit to support a wider ranger of flows such as the one where we need to pass raw data to a caller without assuming its structure. Additionally, this simplifies other types of body's we were sending, such as FormData 🙌

Additional fixes:

fixes #3580, #3807, #3829

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.58%. Comparing base (efa3645) to head (4cb3e05).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3645      +/-   ##
==========================================
- Coverage   83.12%   82.58%   -0.55%     
==========================================
  Files         234        3     -231     
  Lines        2578      155    -2423     
  Branches      273       28     -245     
==========================================
- Hits         2143      128    -2015     
+ Misses        393       14     -379     
+ Partials       42       13      -29     
Components Coverage Δ
Requester Utils ∅ <ø> (∅)
Core ∅ <ø> (∅)
REST 83.63% <ø> (ø)
CLI 82.00% <ø> (ø)
see 231 files with indirect coverage changes

@jdalrymple
Copy link
Copy Markdown
Owner Author

Back on this, haha doing it well is a pain 🫠

@jdalrymple jdalrymple added the breaking Changes are not backwards compatible label Nov 17, 2025
@jdalrymple jdalrymple force-pushed the bug/3580 branch 2 times, most recently from 3cd3b5d to 47f50d5 Compare February 24, 2026 22:10
@jdalrymple jdalrymple force-pushed the bug/3580 branch 2 times, most recently from 7f36469 to 389f039 Compare April 2, 2026 14:06
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Bundle Report

Changes will increase total bundle size by 160.8kB (10.26%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
requester-utils 27.53kB 590 bytes (2.19%) ⬆️
core 1.6MB 160.22kB (11.1%) ⬆️⚠️
rest 89.58kB -8 bytes (-0.01%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: rest

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.js -4 bytes 18.48kB -0.02%
index.mjs -4 bytes 12.71kB -0.03%
view changes for bundle: requester-utils

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.js -12 bytes 7.59kB -0.16%
index.mjs -12 bytes 7.06kB -0.17%
index.d.mts 307 bytes 6.44kB 5.01% ⚠️
index.d.ts 307 bytes 6.44kB 5.01% ⚠️
view changes for bundle: core

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts 5.41kB 489.88kB 1.12%
index.d.ts 5.41kB 489.88kB 1.12%
index.js 74.63kB 278.56kB 36.59% ⚠️
index.mjs 74.63kB 271.25kB 37.95% ⚠️
map.json 153 bytes 73.53kB 0.21%

@jdalrymple jdalrymple changed the title WIP: Fixing default raw data handling refactor: Comprehensive API refactoring and type improvements Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Changes are not backwards compatible type:bug Changes fix a minor bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PackageRegistry.publish not properly uploading files from html file input

1 participant