Prepare for v1.10.0-alpha.2 release; bump dependencies#801
Merged
SgtCoDFish merged 2 commits intomasterfrom May 6, 2026
Merged
Prepare for v1.10.0-alpha.2 release; bump dependencies#801SgtCoDFish merged 2 commits intomasterfrom
SgtCoDFish merged 2 commits intomasterfrom
Conversation
added 2 commits
May 5, 2026 16:59
Signed-off-by: felix.phipps <felix.phipps@cyberark.com>
Signed-off-by: felix.phipps <felix.phipps@cyberark.com>
SgtCoDFish
approved these changes
May 6, 2026
Contributor
SgtCoDFish
left a comment
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Thank you!
Comment on lines
-22
to
-26
| k8s.io/api v0.34.3 | ||
| k8s.io/apimachinery v0.34.3 | ||
| k8s.io/client-go v0.34.3 | ||
| k8s.io/component-base v0.34.3 | ||
| sigs.k8s.io/controller-runtime v0.22.4 |
Contributor
There was a problem hiding this comment.
note: I'm not fully confident that bumping these k8s deps will be totally safe given we'll want to also support older versions of k8s. We'll have to be careful to test this after we merge this PR, and check that the agent still works with the oldest k8s version we can find.
(I can't give a specific concern, but I think it's a focus point!)
Comment on lines
+308
to
+309
| // Note: We used to test with smaller key sizes but the library started to reject such small keys. | ||
| // Therefore, we have removed the test for the time being. |
Contributor
There was a problem hiding this comment.
nb: I suggested replacing this test with a comment. No point in testing that we reject small keys if the library does it for us.
SgtCoDFish
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the per-gatherer excludeAnnotationKeysRegex and excludeLabelKeysRegex config fields, which previously had no effect. Resources with annotation or label keys matching the configured patterns are now excluded entirely from upload, rather than just having those keys stripped from their metadata.