Skip to content

CP-25943: document the migration-precedence proof already covered by this test #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roeezis wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CP-25943: document the migration-precedence proof already covered by this test #828

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07acbb6
CP-25943: document the migration-precedence proof already covered by …
Sep 3, 2026
0162d71
Review: reconcile the two comments and trim to the point
Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions pkg/client/client_cyberark_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ import (
// dataupload code works with the mock CyberArk APIs.
// The environment variables are chosen to match those expected by the mock
// server.
//
// ARK_USERNAME/ARK_SECRET are set here on purpose alongside a non-empty
// serviceID: selectAuthenticator ignores them once serviceID is set, and
// FakeCyberArk's Identity.API is an unreachable `.invalid` host -- a
// mistaken fallback to username/password would fail this test.
func TestCyberArkClient_PostDataReadingsWithOptions_MockAPI(t *testing.T) {
t.Setenv("ARK_SUBDOMAIN", servicediscovery.MockDiscoverySubdomain)
t.Setenv("ARK_USERNAME", "test@example.com")
Expand All @@ -47,12 +52,9 @@ func TestCyberArkClient_PostDataReadingsWithOptions_MockAPI(t *testing.T) {
}

// TestCyberArkClient_PostDataReadingsWithOptions_UsernamePasswordMockAPI is
// the legacy-auth-path counterpart to the Conjur test above. Without it, the
// only integration-level test of NewCyberArk's username/password path is one
// that sets ARK_USERNAME/ARK_SECRET but then also passes a non-empty
// serviceID — which selectAuthenticator prioritises, so it silently exercises
// Conjur regardless of those env vars. This test leaves serviceID empty so
// the username/password path is what's actually under test.
// the legacy-auth-path counterpart to the Conjur test above (see its comment
// for why serviceID must stay empty here for this test to actually exercise
// the username/password path).
func TestCyberArkClient_PostDataReadingsWithOptions_UsernamePasswordMockAPI(t *testing.T) {
t.Setenv("ARK_SUBDOMAIN", servicediscovery.MockDiscoverySubdomain)
httpClient, username, password := testutil.FakeCyberArkUsernamePassword(t)
Expand Down
Loading