Fix psalm incompatibility with class-string<object> notation#333
Merged
joelwurtz merged 1 commit intojolicode:mainfrom Mar 17, 2026
Merged
Conversation
joelwurtz
approved these changes
Mar 17, 2026
Member
joelwurtz
left a comment
There was a problem hiding this comment.
Fine with me, since it works on phpstan also
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Psalm 6 crashes with an uncaught
DocblockParseExceptionwhen scanningsrc/Metadata/Discriminator.phpdue to theclass-string<object>typein the docblock:
This crash occurs during autoload scanning, before analysis even starts,
making it impossible to use Psalm on projects that depend on AutoMapper.
Versions affected:
10.0.36.15.1Fix
Replace
class-string<object>withclass-stringin theDiscriminatorconstructor docblock.
Since every PHP class implicitly extends
object, these two types arestrictly equivalent — no type safety is lost.