Repository navigation
Conversation
get notes, get trash and search filtered by tag with the key "Tag", which gosn-v2 does not handle, so the filter matched every note. Use "TagTitle", and "==" since TagTitle does not support "contains". Fixes jonhadfield#135
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Owner
|
Landed on main as 27fa3e7, with gosn-v2 bumped to include jonhadfield/gosn-v2#108. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135. Depends on jonhadfield/gosn-v2#108: it needs a gosn-v2 release with that fix and a dependency bump here.
Summary
get notes,get trashandsearchfiltered by tag with a key gosn-v2 doesn't handle, so the filter matched every note.items.Filter{ Type: common.SNItemTypeNote, - Key: common.SNItemTypeTag, // "Tag": falls through to default, matches all - Comparison: "contains", // TagTitle has no "contains" + Key: "TagTitle", + Comparison: "==", Value: t, }Evidence
sn get notes --tag sn-cli-pr-teston an account where that tag holds 2 notes:After (this branch + gosn-v2#108 via a local
replace): the 2 notes in the tag.no matches, because of the tag-order bug fixed in gosn-v2#108. That's why this PR shouldn't merge before the bump.Merge Danger
Door: two-way
Blast Radius: tag filtering
--tagonget notes,get trashandsearchnow actually filters. Several--tagvalues must all match (MatchAnyis false). Tag titles are now matched exactly rather than by substring, which is whatcontainssuggested but never did.