Repository navigation
Conversation
The flag was read only when SN_CACHEDB_DIR was set, so on its own it was ignored. The flag already defaults to SN_CACHEDB_DIR, so read it directly. Fixes jonhadfield#139
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Owner
|
Landed on main as e2a8b73. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #139
Summary
The flag's default is already
viper.GetString("cachedb_dir")(main.go:138), so reading the flag covers both the flag andSN_CACHEDB_DIR.Evidence
New test
TestGetOptsCacheDBDirFlag(incmd/sncli/opts_test.go): with--cachedb-dir /tmp/sn-cacheand no env var set, expect/tmp/sn-cache.expected: "/tmp/sn-cache" actual: ""After: passes.
Merge Danger
Door: two-way
Blast Radius: cache path
Only runs that pass
--cachedb-dirwithoutSN_CACHEDB_DIRchange: they now use the directory they asked for.