test: add edge case coverage for createError factory#154
Open
mahmoodhamdi wants to merge 1 commit intojshttp:masterfrom
Open
test: add edge case coverage for createError factory#154mahmoodhamdi wants to merge 1 commit intojshttp:masterfrom
mahmoodhamdi wants to merge 1 commit intojshttp:masterfrom
Conversation
Add tests for several untested scenarios: - createError() with no arguments defaults to 500 - err.statusCode extraction when err.status is not set - err.status takes precedence over err.statusCode - expose property is true for 4xx, false for 5xx (factory and constructors) - custom headers attachment via properties object - TypeError thrown for unsupported argument types (boolean, function) - named constructors with custom messages and null message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added 16 new test cases covering several untested edge cases in the
createErrorfactory and named constructors.Why
I use
http-errorsextensively in my Express middleware and noticed some scenarios that lack test coverage while reading through the source. These tests document and verify existing behavior for edge cases that users commonly encounter.New test cases
createError()with no argumentserr.statusCodeextractionstatusCodebut notstatus,statusCodeis usedstatusandstatusCodeexist,statustakes precedenceexposepropertytruefor 4xx errors via both factory and named constructorsfalsefor 5xx errors via both factory and named constructorsCustom
headersvia propertiesundefinedby defaultArgument type validation
Named constructors with custom messages
nullmessage falls back to default status messageTesting
All existing tests continue to pass. Linting passes.