Fix/add leverage bounds validation - #31
Open
MayurK-cmd wants to merge 2 commits into
Open
MayurK-cmd wants to merge 2 commits into
MayurK-cmd wants to merge 2 commits into
Conversation
Both SpotCommand and PerpsCommand had duplicate parseTimestamp() methods with inconsistent behavior. Created shared DateConverter.parseTimestamp() utility to ensure consistent timestamp handling across all commands. Changes: - Create src/lib/DateConverter.ts with parseTimestamp() method - Update SpotCommand to use DateConverter.parseTimestamp() - Update PerpsCommand to use DateConverter.parseTimestamp() - Reduces code duplication by 2 implementations
The perps open command now validates that leverage is between 1 and 100, rejecting values outside this range with a clear error message. Changes: - Add leverage bounds check (1 <= leverage <= 100) inPerpsCommand.open() - Reject non-numeric leverage values - Add4 e2e tests covering boundary cases and valid range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: add leverage bounds validation to perps open command
Users can now specify any leverage value to
perps open --leverage, butthere are real bounds (1-100x) beyond which the Perps protocol rejects
positions. Validate leverage at the CLI before sending to the API so users
get immediate, clear feedback instead of a cryptic API error.
Changes:
Fixes: #26