Conversation
sauraww
changed the title
sauraww
changed the title
sauraww
force-pushed
the
tests/js-openfeature-tests
branch
from
4c70226 to
06b01ee
Compare
|
needs to be rebased |
sauraww
force-pushed
the
tests/js-openfeature-tests
branch
3 times, most recently
from
6d15eee to
2dcf40b
Compare
| if (experiments && experimentgroups) { | ||
| this.cachedExperiments = experiments; | ||
| this.cachedExperimentGroups = experimentgroups; | ||
| this.lastUpdated = new Date(); |
There was a problem hiding this comment.
I don't think it exists
There was a problem hiding this comment.
Datron
left a comment
Datron
left a comment
There was a problem hiding this comment.
Do we need experiment group support in the provider? This is a resolution time thing right? Experiment bucketing should sort it out
What If someone needs direct experiment group information for debugging ? |
| if (this.defaults) { | ||
| console.log('Falling back to defaults'); | ||
| if (isNetworkError(error)) { | ||
| console.warn('SuperpositionProvider: Using fallback configuration - server connection failed'); |
There was a problem hiding this comment.
Why warn? IMO this should be an error log, less likely for people to miss it that way. Also, feel like this would be a better way to phrase the error: Server connection failed, using fallback configuration. Basically, highlight the problem first.
sauraww
force-pushed
the
tests/js-openfeature-tests
branch
from
2dcf40b to
70ab56e
Compare
|
Closing because of redesign |
4 participants
Problem
Describe the problem you are trying to solve here
Solution
Provide a brief summary of your solution so that reviewers can understand your code
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
Things needed to be done before deploying this change (if any)
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes
Possible Issues in the future
Describe any possible issues that could occur because of this change