Conversation
|
Failed to assess the semver bump. See logs for details. |
go run ./cmd/scaffold-controller -interactive=false \
-kind=ShareNetwork \
-gophercloud-client=NewSharedFilesystemV2 \
-gophercloud-module=github.com/gophercloud/gophercloud/v2/openstack/sharedfilesystems/v2/sharenetworks \
-gophercloud-type=ShareNetwork \
-openstack-json-object=share_network \
-optional-create-dependency=Network \
-optional-create-dependency=Subnet
Signed-off-by: Daniel Lawton <dlawton@redhat.com>
dlaw4608
force-pushed
the
share_network
branch
from
4f9c96e to
46a1765
Compare
dlaw4608
force-pushed
the
share_network
branch
2 times, most recently
from
79282c8 to
08867bf
Compare
winiciusallan
left a comment
winiciusallan
left a comment
There was a problem hiding this comment.
Hey @dlaw4608, I left a few comments, but I need some more time to take a look at the other test scenarios. For now, let me know what you think about what it is commented.
api/v1alpha1/sharenetwork_types.go
Outdated
| @@ -38,14 +40,6 @@ type ShareNetworkResourceSpec struct { | |||
| // +optional | |||
| // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="subnetRef is immutable" | |||
| SubnetRef *KubernetesNameRef `json:"subnetRef,omitempty"` | |||
There was a problem hiding this comment.
Looks like both NetworkRef and SubnetRef are required according to the docs.
Specify both a neutron network and a neutron subnet that belongs to that neutron network.
Also, you've specified these two fields in the create-minimal, so I'm assuming that the claim above is true. Isn't it better to define these two fields as required and remove the omitempty tag?
| const ShareNetworkStatusInUse = "in-use" | ||
| const ShareNetworkStatusDeleting = "deleting" | ||
|
|
||
| const ( |
There was a problem hiding this comment.
I believe we're not using any of these statuses throughout the code, and it looks like we don't have a status field in the ShareNetwork struct on Gophercloud's side. Is this useful?
Maybe do we need to create an issue to address this?
| - celExpr: "sharenetwork.status.resource.name == 'sharenetwork-create-full-override'" | ||
| - celExpr: "sharenetwork.status.resource.description == 'ShareNetwork from \"create full\" test'" |
There was a problem hiding this comment.
We don't need this check since KUTTL already matches fields from declaration vs status.
Implements ShareNetwork controller to manage Manila share networks. - E2E tests included - API configured - Manila enabled in CI Signed-off-by: Daniel Lawton <dlawton@redhat.com> Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2 participants
Add support for Openstack Manila Service Share Network resource
Closes: #687