Fix YAML ScannerError on Windows credentials_path#30
Open
JesseLeeStringer wants to merge 1 commit intokLOsk:mainfrom
Open
Fix YAML ScannerError on Windows credentials_path#30JesseLeeStringer wants to merge 1 commit intokLOsk:mainfrom
JesseLeeStringer wants to merge 1 commit intokLOsk:mainfrom
Conversation
`adloop init` writes Windows paths like `c:\Users\user\.adloop\credentials.json` inside double-quoted YAML, which the parser treats as escape sequences (`\U` begins a Unicode escape). Loading the resulting config raises ScannerError and the MCP server fails to start. Switch to single-quoted YAML for credentials_path; single-quoted strings are literal so backslashes are safe. Embedded single quotes are escaped by doubling per the YAML 1.1 spec. Adds tests/test_cli.py covering the Windows path, POSIX path, embedded-apostrophe, and no-credentials-path cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adloop initwrites Windows paths likec:\Users\user\.adloop\credentials.jsoninside double-quoted YAML, which the parser treats as escape sequences (\Ubegins a Unicode escape). Loading the resulting config raises ScannerError and the MCP server fails to start.Switch to single-quoted YAML for credentials_path; single-quoted strings are literal so backslashes are safe. Embedded single quotes are escaped by doubling per the YAML 1.1 spec. Adds tests/test_cli.py covering the Windows path, POSIX path, embedded-apostrophe, and no-credentials-path cases.