Skip to content

fix: Add toolchain env vars#58

Merged
secana merged 6 commits intokellnr:mainfrom
vmoudy:vmoudy/add-toolchain-env-vars
Feb 21, 2026
Merged

fix: Add toolchain env vars#58
secana merged 6 commits intokellnr:mainfrom
vmoudy:vmoudy/add-toolchain-env-vars

Conversation

@vmoudy
Copy link

@vmoudy vmoudy commented Feb 13, 2026

No description provided.

@nyurik nyurik requested a review from secana February 13, 2026 23:07
@vmoudy vmoudy changed the title Add toolchain env vars fix: Add toolchain env vars Feb 13, 2026
name: {{ .Values.configMap.name | quote }}
data:
{{- include "kellnr.envVars" . | nindent 2 }}
{{- include "kellnr.envVars" . | nindent 2 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no trailing newline? I thought we had editor config at the top to dictate all editors auto-add them

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ This is in main and I removed them after rebasing for consistency.

@secana secana merged commit 38b3888 into kellnr:main Feb 21, 2026
2 checks passed
@vmoudy vmoudy deleted the vmoudy/add-toolchain-env-vars branch February 25, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants