Repository navigation
ci: make Firefox signing safe to retry - #5
Merged
Merged
Conversation
kermitsxb
marked this pull request as ready for review
October 1, 2026 12:56
kermitsxb
added a commit
that referenced
this pull request
Oct 1, 2026
* fix(extension): map Firefox native port errors * feat(build): derive the Firefox manifest * feat(build): build and sign the Firefox extension * feat(install): register the native host for Firefox * docs: Firefox install and signing * fix(extension): map the Firefox refused-host error * chore: build before Firefox lint and sign; doc fixes * ci: build and release both extensions with release-please (#4) * ci: build both extensions and release them on version tags * docs: releases * ci: cut releases with release-please * docs: release-please releases * ci: make Firefox signing safe to retry (#5) * ci: reuse already-submitted AMO versions when signing * docs: Firefox signing retries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4 (merged into
feat/firefox-extension); lands in #3.Summary
scripts/sign-firefox.mjsreplaces the directweb-ext signcall innpm run sign:firefox. It first asks AMO for the current version:web-ext sign(unlisted).The artifact is always
web-ext-artifacts/github-orca-firefox-X.Y.Z.xpi. AMO versions are immutable, so a re-run job (after an approval timeout or a failed download or upload) recovers the XPI instead of failing on "version already exists". The script stops without submitting on any other HTTP error, on a network failure, or on unexpected metadata.release.yml:release-pleasenowneeds: build, so no release is cut from a brokenmain;assetsuploads the deterministic XPI path directly.README / AGENTS.md document the retry behaviour.
Verification
npm testpasses: 251 tests, including the newsign-firefoxtests (already signed, absent, pending, retry after a failed download, HTTP and network errors, bad metadata, approval timeout).npm run typecheckis clean.actionlintpasses.web-ext lintreports 0 errors and 2 known warnings.Notes
web-ext/util/submit-addon, which is an internal web-ext module. A web-ext upgrade could break it, so re-runnpm testafter bumping web-ext.