Repository navigation
fix(firefox): raise strict_min_version to match data_collection_permissions - #8
Merged
Merged
Conversation
…ssions data_collection_permissions is supported from Firefox 140 (desktop) and 142 (Android); web-ext lint warned that strict_min_version 128 predates it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
web-ext lint reported two warnings:
strict_min_version128 predates support forbrowser_specific_settings.gecko.data_collection_permissions(Firefox 140 desktop, 142 Android).gecko.strict_min_version→140.0(also the current ESR)gecko_android.strict_min_version→142.0npm run lint:firefox: 0 errors, 0 warnings. Tests, typecheck and build pass.