Repository navigation
CLI: Update SDK to f737b63ffd168cc67bf0158b961ca3275c94bd1c and add new commands/flags - #291
Merged
Merged
Conversation
- Bump github.com/kernel/kernel-go-sdk to c203c7e5a0c9781bcaf1056cb7665fd670867c4b - Add `kernel vaults get-encryption-key <vault>` for client.Vaults.GetEncryptionKey - Document encrypted_value (CredentialVaultFieldInputParam/UpdateParam.EncryptedValue) in credentials create/update help; it passes through --spec-file JSON Tested: vaults get-encryption-key (table, -o json, not-found error); credentials create and update with a real ECDH-ES/A256GCM encrypted_value (item ready, version bumped); vault cleaned up. go test ./cmd passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…2.0) SDK change is a release version bump only (no API changes); full enumeration of api.md methods against CLI commands found no new gaps. Tested: go build ./..., go test ./cmd/... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Bump github.com/kernel/kernel-go-sdk to 6f3ae15351013fd71e5d554b69d7e532e1e592db - Add --video-memory (2GiB|4GiB) to `kernel browsers create` for BrowserNewParams.VideoMemory (GPU VRAM tier) - Show Video Memory in browser get/create output when present Tested: browsers create --gpu --video-memory 2GiB (get shows Video Memory 2GiB, Memory 6GiB; deleted afterwards); --video-memory 4GiB reached the API (tier at capacity); invalid values rejected client-side; go test ./cmd -run TestBrowsers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SDK change is documentation-only (1Password fill_unknown may now carry error_code autosubmitFailed; inspect the page after an uncertain fill). The CLI already prints error_code for any 1pw_fill status and its help text already reflects the new guidance. Full enumeration found no gaps. Tested: go build ./..., go vet ./..., go test ./... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yummybomb
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Go SDK to f737b63ffd168cc67bf0158b961ca3275c94bd1c and adds CLI commands/flags for new SDK methods.
SDK Update
fill_unknowncan now carryerror_code: autosubmitFailed, and after an uncertain fill the caller should inspect the page. The CLI already printserror_codefor every1pw_fillstatus, and its help text already gives this guidance, so no code changes were needed for it.video_memoryfor the 4GiB VRAM GPU browser tier.Coverage Analysis
This PR was generated by performing a full enumeration of SDK methods and CLI commands. After this PR, every method in api.md has a CLI command. The only exception is
ConfigRegistry.*, which is skipped because those endpoints are markedx-cli-skip.New Commands
kernel vaults get-encryption-key <vault>forclient.Vaults.GetEncryptionKey(). It shows a table by default, and-o jsonreturns the raw key response.New Flags
--video-memoryonkernel browsers createforBrowserNewParams.VideoMemory. It accepts2GiB(the default: 4 vCPU, 6GiB memory) or4GiB(8 vCPU, 12GiB memory), matched case-insensitively and checked before the request is sent. It requires--gpu.browsers getandcreatenow show a "Video Memory" row when the API returns one.encrypted_valuefield (CredentialVaultFieldInputParam.EncryptedValue,CredentialVaultFieldUpdateParam.EncryptedValue) goes through the existing--spec-fileJSON onvaults credentials create/update. The help text and README now describe it.Testing
go build ./...,go vet ./...andgo test ./...all pass.browsers create --gpu --video-memory 2GiB -t 30: the session was created, andbrowsers getshowedGPU true,Memory 6GiB,Video Memory 2GiB. The test browser was deleted afterwards.browsers create --gpu --video-memory 4GiB: the API received the 4GiB tier but returnedNo_gpu_browsers_available(at capacity), so no 4GiB session was created.--video-memory 3GiBis rejected on the client with a clear error. A new unit test,TestBrowsersCreate_WithVideoMemory, covers this.vaults get-encryption-key: table output,-o jsonoutput, and the not-found error all checked.encrypted_value. The item became ready, and the update bumped the version from 1 to 2.Triggered by: kernel/kernel-go-sdk@f737b63
Reviewer: @kernel-internal[bot]
🤖 Generated with Claude Code
Note
Low Risk
Mostly new CLI flags/commands and docs atop the SDK; credential encryption still flows through existing spec-file JSON without new local crypto logic.
Overview
Updates kernel-go-sdk and exposes two new API surfaces in the CLI.
Adds
kernel vaults get-encryption-keyso custom credential-collection apps can fetch a vault’s public JWK (kid, ECDH-ES / A256GCM) for browser-side JWE encryption, with table or-o jsonoutput. README andvaults credentialshelp now documentencrypted_valueas an alternative tovalueon create/update specs (mutually exclusive).Adds
--video-memoryonkernel browsers create(2GiB/4GiB, case-insensitive client validation; omitted leaves the API default). Create passes it through toBrowserNewParams, andbrowsers get/create detail show Video Memory when present.TestBrowsersCreate_WithVideoMemorycovers mapping, omission, and invalid sizes.Reviewed by Cursor Bugbot for commit 456553a. Bugbot is set up for automated code reviews on this repo. Configure here.