Repository navigation
Conversation
Sayan-
marked this pull request as ready for review
October 9, 2026 23:29
Sayan-
force-pushed
the
hypeship/fix-pool-acquire-204
branch
from
October 10, 2026 00:00
ed5726b to
531b974
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type
browserPools.acquire()as returning a browser ornull. The SDK already parses HTTP 204 asnull; the return type now reflects that long-poll outcome without changing API behavior or adding automatic retries.Validation
Added mock response tests for 200, 204, and 404, including a check that 204 does not trigger an automatic retry. All 3 focused tests passed, and TypeScript type checking passed.
The change was not exercised against a live pool.
The SDK's separate 60-second request timeout can still expire before a longer API poll reaches 204.
Generation and release
This custom SDK change targets
next, the branch used for the versioned release PR. After that release reachesmain, production changes must back-sync to SDK staging and the nextstlcbuild must preserve this behavior. Merge the resulting custom-code tracking PR in the API configuration repo before relying on a later generation. The API's existing OpenAPI contract already documents the 200, 204, and 404 outcomes.Note
Low Risk
Type-only alignment with existing 204→null parsing plus tests; callers may need explicit null checks at compile time.
Overview
Updates the TypeScript return type of
browserPools.acquire()toBrowserPoolAcquireResponse | null, matching existing runtime behavior where a long-poll HTTP 204 (no browser available within the wait window) is already parsed asnull. No request/retry logic changes.Adds focused API tests for 200 (session payload), 204 (
nulland a singlefetchcall), and 404 (NotFoundError).Reviewed by Cursor Bugbot for commit 531b974. Bugbot is set up for automated code reviews on this repo. Configure here.