Security: Command Injection in SSH Storage Backend - #3177
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The `_upload` method in `StorageSSH` constructs a shell command to create remote directories using `f"mkdir -p {dst_dir}"`. The `dst_dir` variable is derived from `dest_path` and file destination names, which are not sanitized. If a malicious path is provided, it can result in arbitrary command execution on the remote SSH server.
Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Command Injection in SSH Storage Backend
Problem
Severity:
High| File:kernelci/storage/ssh.py:L48The
_uploadmethod inStorageSSHconstructs a shell command to create remote directories usingf"mkdir -p {dst_dir}". Thedst_dirvariable is derived fromdest_pathand file destination names, which are not sanitized. If a malicious path is provided, it can result in arbitrary command execution on the remote SSH server.Solution
Avoid using
exec_commandwith shell string interpolation for path creation. Useparamiko's SFTP capabilities (e.g.,self._scp.sftp_client().mkdir) or properly shell-escape thedst_dirpath usingshlex.quote().Changes
kernelci/storage/ssh.py(modified)