feat(web): ensure all child spaces are notified when parent reaches end of a correction path 🚂#15162
Open
jahorton wants to merge 3 commits intofeat/web/multi-token-correctorfrom
Open
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
jahorton
changed the base branch from
docs/web/add-search-space-doc
to
feat/web/cluster-splitting-and-merging
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
dadefba to
ec12918
Compare
jahorton
force-pushed
the
feat/web/search-space-node-propagation
branch
from
b31bcad to
c303355
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
5 times, most recently
from
c31523a to
8f7363d
Compare
jahorton
force-pushed
the
feat/web/search-space-node-propagation
branch
3 times, most recently
from
beafeb6 to
36df714
Compare
jahorton
force-pushed
the
feat/web/search-space-node-propagation
branch
from
c2e0427 to
3713e6a
Compare
jahorton
changed the base branch from
epic/autocorrect
to
refactor/web/root-and-legacy-spur-tests
jahorton
force-pushed
the
feat/web/search-space-node-propagation
branch
3 times, most recently
from
b0724e2 to
c5f9b66
Compare
jahorton
force-pushed
the
refactor/web/root-and-legacy-spur-tests
branch
2 times, most recently
from
ea5e3e5 to
052f1f1
Compare
jahorton
force-pushed
the
feat/web/search-space-node-propagation
branch
from
c5f9b66 to
91cf42e
Compare
jahorton
changed the base branch from
refactor/web/root-and-legacy-spur-tests
to
refactor/web/realign-tokenization
jahorton
force-pushed
the
feat/web/search-space-node-propagation
branch
from
8800920 to
c9b2859
Compare
Base automatically changed from
refactor/web/realign-tokenization
to
epic/autocorrect
March 16, 2026 13:12
jahorton
force-pushed
the
feat/web/search-space-node-propagation
branch
from
c9b2859 to
8dedc59
Compare
jahorton
changed the base branch from
epic/autocorrect
to
feat/web/multi-token-corrector
jahorton
force-pushed
the
feat/web/search-space-node-propagation
branch
2 times, most recently
from
b227e9e to
d71345c
Compare
jahorton
force-pushed
the
feat/web/multi-token-corrector
branch
from
4d05f5e to
7e594e0
Compare
…nd of a correction path Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
feat/web/search-space-node-propagation
branch
from
57d836b to
bde82ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up until now, the SearchQuotientNode types have always been connected as a "linked list" of sorts, without variations, for any given context. With only one tokenization under consideration, we never had to worry about ensuring how results propagate from parent to child - the call was always direct, and there was ever only a one-to-one relationship between parent and child.
However, with upcoming whitespace-correction work, this will change. The correction-search graph will become a full-on graph, with one-to-many relationships existing from parent to children. We need to add internal infrastructure within the
SearchQuotientNodetyping that helps ensure all children are properly able to extend the search results on their parent quotient nodes, regardless of the order in which each child is called upon for search results.Build-bot: skip build:web
Test-bot: skip