chore(core): Remove km_core_keyboard_attrs.folder_path 🎼#15471
chore(core): Remove km_core_keyboard_attrs.folder_path 🎼#15471ermshiperete merged 2 commits intoepic/web-corefrom
km_core_keyboard_attrs.folder_path 🎼#15471Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
km_core_keyboard_attrs.folder_pathkm_core_keyboard_attrs.folder_path 🎼
20cd352 to
812b93e
Compare
812b93e to
0422b3f
Compare
mcdurdin
left a comment
There was a problem hiding this comment.
I am not sure about this change. We have not published an API stability policy but perhaps we need to. For example GNOME's policy.
Removal of fields is not backwardly compatible; the question in my mind is if we need to maintain backward compatibility for Core because it is normally tightly linked to a release. (If we have other consumers of the Keyman Core API, then this will become a more serious question.)
If we do publish this, it is a Keyman Core API change that needs to be listed in our 19.0 changes wiki
|
After discussion, decided to go ahead and update this API along with corresponding release note. |
|
Oops - there's also |
PR #12769 removed
km_core_keyboard_loadthat allowed loading a keyboard from a path. Instead we now pass a BLOB to core to load a keyboard. With the function gone there is no longer a need to have a field with the path.Follow-up-of: #12497
Related-to: #12769
Test-bot: skip