Fix cloudevents import in Python code - #6680
Open
dod38fr wants to merge 1 commit into
Open
Conversation
This commit fixes the following error seen when building
ML-sentiment-analysis:
---> Running application from script (app.sh) ...
ERROR:root:Function must export either 'new' or 'handle'
Traceback (most recent call last):
File "/opt/app-root/src/.func/build/service/main.py", line 13, in <module>
from function import new as handler # type: ignore[import]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/app-root/lib64/python3.11/site-packages/function/__init__.py", line 1, in <module>
from .func import new
File "/opt/app-root/lib64/python3.11/site-packages/function/func.py", line 2, in <module>
from cloudevents.http import CloudEvent
ModuleNotFoundError: No module named 'cloudevents.http'
Python doc (https://pypi.org/project/cloudevents/) mentions that
CloudEvent is imported with:
from cloudevents.core.v1.event import CloudEvent
Even though I've modified all occurrences of "import CloudEvent", I've
tested this change only on ML-sentiment-analysis
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dod38fr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome @dod38fr! It looks like this is your first PR to knative/docs 🎉 |
knative-prow
Bot
added
the
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the following error seen when building ML-sentiment-analysis:
Proposed Changes
Python doc (https://pypi.org/project/cloudevents/) mentions that CloudEvent is imported with:
So I've updated all occurrences of "import CloudEvent" and I've validated this change on ML-sentiment-analysis.