hack: remove deprecated export GO111MODULE=on#8996
hack: remove deprecated export GO111MODULE=on#8996Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Conversation
GO111MODULE=on is a no-op on Go 1.21+ and the module already declares go 1.25.0 in go.mod. Remove the export from hack/verify-codegen.sh, hack/e2e-debug.sh, and test/e2e-common.sh.
knative-prow
bot
added
the
area/test-and-release
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
bot
added
the
size/XS
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
bot
added
the
needs-ok-to-test
There was a problem hiding this comment.
Pull request overview
Removes a now-deprecated GO111MODULE=on environment export from a few repository shell scripts, aligning the scripts with modern Go module behavior (and the repo’s declared Go version).
Changes:
- Remove
export GO111MODULE=onfromtest/e2e-common.sh. - Remove
export GO111MODULE=onfromhack/verify-codegen.sh. - Remove
export GO111MODULE=onfromhack/e2e-debug.sh.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/e2e-common.sh |
Drops the deprecated module-flag export before sourcing shared e2e test helpers. |
hack/verify-codegen.sh |
Removes the deprecated module-flag export from the codegen verification script. |
hack/e2e-debug.sh |
Removes the deprecated module-flag export from the e2e debug runner script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #8995
Summary
export GO111MODULE=onfromhack/verify-codegen.sh,hack/e2e-debug.sh, andtest/e2e-common.shGO111MODULE=onis ignored on Go 1.21+ and this repo declaresgo 1.25.0ingo.mod.