hack: replace fragile awk pipeline with 'go env GOARCH' in install.sh#9000
hack: replace fragile awk pipeline with 'go env GOARCH' in install.sh#9000Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Conversation
The previous 'go env | grep GOARCH | awk -F\'' pipeline is fragile: it depends on the specific output format of 'go env' which can vary. 'go env GOARCH' is the canonical, documented way to read a single Go environment variable and is simpler and more reliable.
knative-prow
bot
added
the
area/test-and-release
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
bot
added
size/XS
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
This PR improves the robustness of the local development install script by switching to Go’s canonical single-variable environment query for detecting the target architecture, aligning with the documented go env <VAR> usage.
Changes:
- Replace a fragile
go env | grep ... | awk ...pipeline withgo env GOARCHto populateKO_ARCH. - Keep
KO_FLAGSplatform selection behavior the same while makingKO_ARCHdetection more stable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #8999
Summary
go env | grep GOARCH | awk -F\'' '{print $2}'with$(go env GOARCH)inhack/install.shgo env GOARCHis the canonical, documented way to read a single Go environment variable.