Adding rules to CONTRIBUTING.md#4594
Open
CsatariGergely wants to merge 1 commit into
Open
Conversation
CsatariGergely
commented
Jun 17, 2026
CsatariGergely
commented
Contributor
- Current CODEOWNER.md based rules for pr approvals. This will be changed ot the maintainer and contributor groups based rules once we agreed to apply them to all the repos.
- Rules for stale prs
- Current CODEOWNER.md based rules for pr approvals. This will be changed ot the maintainer and contributor groups based rules once we agreed to apply them to all the repos. - Rules for stale prs Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
Bot
added
size:S
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project contribution guidelines by expanding the Code reviews section in CONTRIBUTING.md, adding explicit expectations around PR approvals and handling of stale PRs.
Changes:
- Reflows and reformats the existing “Code reviews” text and checklist for readability.
- Adds a requirement for PR approvals based on the
CODEOWNERSfile. - Introduces a “Stale PRs” policy describing when inactive PRs may be closed and how they can be resumed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+61
to
+62
| All pr-s should be approved by at least two memebrs of the [CODEOWNERS](./CODEOWNERS) file, have all | ||
| checks passed and all discussions resolved before merge. |
| All pr-s should be approved by at least two memebrs of the [CODEOWNERS](./CODEOWNERS) file, have all | ||
| checks passed and all discussions resolved before merge. | ||
|
|
||
| ### Stale pr-s |
Comment on lines
+66
to
+68
| In the case if the comments of a pr are not addressed for more than 2 weeks the pr will be closed. | ||
| The pr can be re-opened any time and the work can be continued if there is a willingness to continue | ||
| the work after a break. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.