Skip to content

feat(FR-1371): Add model deployment launcher UI#4156

Closed
agatha197 wants to merge 1 commit intofeat_FR-1371_/new-deployment-uifrom
feat_FR-1371_/model-deployment-launcher-ui
Closed

feat(FR-1371): Add model deployment launcher UI#4156
agatha197 wants to merge 1 commit intofeat_FR-1371_/new-deployment-uifrom
feat_FR-1371_/model-deployment-launcher-ui

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Aug 14, 2025

Resolves #4144 (FR-1371)

Add Deployment Launcher Page

This PR adds a new deployment launcher page that allows users to create model deployments through a step-by-step wizard interface. The launcher guides users through configuring deployment metadata, network settings, deployment strategies, initial revision details, and resource allocation.

Key features:

  • Three-step wizard interface (Deployment, Initial Revision, Confirm & Deploy)
  • Form state persistence in URL parameters for easy sharing and navigation
  • Comprehensive preview screen before final deployment
  • Support for various deployment strategies (Rolling, Blue-Green)
  • Configuration options for runtime variants, model mounts, and environment variables

The PR also adds navigation from the deployment list page to this new launcher and integrates with the existing deployment system.

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Copy Markdown
Contributor Author

agatha197 commented Aug 14, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 14, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.35% (-0.06% 🔻)
504/11578
🔴 Branches
3.46% (-0.1% 🔻)
285/8226
🔴 Functions
2.49% (-0.05% 🔻)
90/3619
🔴 Lines
4.33% (-0.06% 🔻)
490/11320
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / DeploymentMetadataFormItem.tsx
0% 100% 0% 0%
🔴
... / DeploymentNetworkAccessFormItem.tsx
0% 100% 0% 0%
🔴
... / DeploymentStrategyFormItem.tsx
0% 0% 0% 0%
🔴
... / DeploymentRevisionRuntimeAndMountFormItem.tsx
0% 0% 0% 0%
🔴
... / DeploymentLauncherPreview.tsx
0% 0% 0% 0%
🔴
... / DeploymentDetailPage.tsx
0% 0% 0% 0%
🔴
... / DeploymentLauncherPage.tsx
0% 0% 0% 0%
🔴
... / DeploymentCreateModal.tsx
0% 0% 0% 0%
🔴
... / DeploymentCreatePage.tsx
0% 100% 0% 0%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 helper/index.tsx
40.93% (-2% 🔻)
34.72% (-5.4% 🔻)
23.21% (-3.32% 🔻)
41.67% (-1.84% 🔻)

Test suite run success

114 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from 15e93e6

@agatha197 agatha197 force-pushed the feat_FR-1371_/model-deployment-launcher-ui branch 3 times, most recently from 1767140 to bdb5c8c Compare August 18, 2025 15:59
@agatha197 agatha197 force-pushed the feat_FR-1371_/new-deployment-ui branch from 5bbeb43 to 52128b3 Compare August 19, 2025 02:25
@agatha197 agatha197 force-pushed the feat_FR-1371_/model-deployment-launcher-ui branch 6 times, most recently from 7c5d21e to c84bfd4 Compare August 20, 2025 02:29
@agatha197 agatha197 force-pushed the feat_FR-1371_/new-deployment-ui branch from 52128b3 to 8f5b864 Compare August 20, 2025 02:29
@agatha197 agatha197 force-pushed the feat_FR-1371_/model-deployment-launcher-ui branch 2 times, most recently from 96c1fdc to 2764322 Compare August 20, 2025 05:27
@agatha197 agatha197 changed the base branch from feat_FR-1371_/new-deployment-ui to graphite-base/4156 August 20, 2025 05:43
@agatha197 agatha197 force-pushed the feat_FR-1371_/model-deployment-launcher-ui branch from 2764322 to f0914f3 Compare August 21, 2025 00:59
@agatha197 agatha197 changed the base branch from graphite-base/4156 to feat_FR-1371_/new-deployment-ui August 21, 2025 00:59
@agatha197 agatha197 force-pushed the feat_FR-1371_/model-deployment-launcher-ui branch 5 times, most recently from bb66b1c to d93c8ce Compare August 22, 2025 04:18
@agatha197 agatha197 force-pushed the feat_FR-1371_/model-deployment-launcher-ui branch from acba15e to 71a0b39 Compare August 26, 2025 04:51
@agatha197 agatha197 force-pushed the feat_FR-1371_/new-deployment-ui branch 2 times, most recently from 49eca1c to 1e1d24c Compare August 26, 2025 05:33
@agatha197 agatha197 force-pushed the feat_FR-1371_/model-deployment-launcher-ui branch 2 times, most recently from 755f215 to 57c46e6 Compare August 26, 2025 05:40
@agatha197 agatha197 force-pushed the feat_FR-1371_/new-deployment-ui branch from 1e1d24c to 43173e4 Compare August 26, 2025 05:40
@agatha197 agatha197 changed the base branch from feat_FR-1371_/new-deployment-ui to graphite-base/4156 August 26, 2025 05:56
@agatha197 agatha197 force-pushed the feat_FR-1371_/model-deployment-launcher-ui branch from 57c46e6 to 960a9ca Compare August 26, 2025 07:55
@agatha197 agatha197 changed the base branch from graphite-base/4156 to feat_FR-1371_/new-deployment-ui August 26, 2025 07:55
@agatha197 agatha197 force-pushed the feat_FR-1371_/new-deployment-ui branch from ba515bc to 5a462f0 Compare August 26, 2025 10:15
@agatha197 agatha197 force-pushed the feat_FR-1371_/model-deployment-launcher-ui branch 2 times, most recently from 2417826 to db74f15 Compare August 27, 2025 01:34
@agatha197 agatha197 force-pushed the feat_FR-1371_/new-deployment-ui branch from 5a462f0 to 1771466 Compare August 27, 2025 01:34
@agatha197 agatha197 changed the base branch from feat_FR-1371_/new-deployment-ui to graphite-base/4156 August 27, 2025 11:17
@agatha197 agatha197 force-pushed the feat_FR-1371_/model-deployment-launcher-ui branch from db74f15 to 49e4647 Compare August 27, 2025 11:36
@agatha197 agatha197 changed the base branch from graphite-base/4156 to feat_FR-1371_/new-deployment-ui August 27, 2025 11:36
@agatha197 agatha197 force-pushed the feat_FR-1371_/new-deployment-ui branch from bc6fd85 to 38bb2be Compare August 28, 2025 06:05
@agatha197 agatha197 force-pushed the feat_FR-1371_/model-deployment-launcher-ui branch from 49e4647 to c4bc4b6 Compare August 28, 2025 06:05
@agatha197 agatha197 force-pushed the feat_FR-1371_/new-deployment-ui branch from 38bb2be to ea57739 Compare August 28, 2025 07:21
@agatha197 agatha197 force-pushed the feat_FR-1371_/model-deployment-launcher-ui branch from c4bc4b6 to 935bf75 Compare August 28, 2025 07:21
@agatha197
Copy link
Copy Markdown
Contributor Author

This PR is superseded and resolved by #6917. Closing as part of stack cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC stale:rewrite Needs full rewrite due to structural changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant