Repository navigation
fix: align Lean justifiability overflow semantics #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ss1738
wants to merge
1
commit into
lambdaclass:lean-formalization
from
ss1738:draft/lean-justifiability-overflow
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /- | ||
| Copyright (c) 2026 ethlambda contributors. All rights reserved. | ||
| Released under Apache 2.0 license as described in the file LICENSE. | ||
| -/ | ||
| import EthLambda.Justifiability | ||
|
|
||
| /-! | ||
| # Fixed-Width Arithmetic Regression | ||
|
|
||
| The pronic discriminant for this value overflows UInt64. Rust uses checked | ||
| arithmetic, so the Lean FFI implementation must reject it as well. | ||
| -/ | ||
|
|
||
| /-- `4 * delta + 1` would wrap to `9` under unchecked UInt64 arithmetic. -/ | ||
| example : justifiable 4611686018427387906 = false := by | ||
| decide | ||
|
|
||
| /-- The largest delta whose pronic discriminant fits remains evaluable. -/ | ||
| example : justifiable 4611686018427387903 = false := by | ||
| decide | ||
|
|
||
| /-- Perfect-square detection remains valid at the first overflowing-pronic delta. -/ | ||
| example : justifiable 4611686018427387904 = true := by | ||
| decide | ||
|
|
||
| /-- Values above the checked-pronic range do not wrap into false positives. -/ | ||
| example : justifiable 18446744073709551615 = false := by | ||
| decide |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this work correctly with all values if possible, otherwise just leaving it at < 2**62 like before is enough. Making this return a fixed wrong result, true or false, isn't really a fix here.