build(deps): pin time to 0.3.47 to avoid aws-smithy-types E0119#7255
Closed
brendanclement wants to merge 1 commit into
Closed
build(deps): pin time to 0.3.47 to avoid aws-smithy-types E0119#7255brendanclement wants to merge 1 commit into
brendanclement wants to merge 1 commit into
Conversation
8b17740 to
053971f
Compare
This was referenced Jun 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dantasse
approved these changes
Jun 12, 2026
Contributor
|
I think we can close this as the upstream issue has been addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
time 0.3.48(published 2026-06-12) added aFromimpl on an associated type that rustc's coherence checker treats as conflicting with any crate carrying a generic blanketFrom<T>impl. For us that isaws-smithy-types1.4.5'simpl<T> From<T> for CanDisable<T>, which fails to compile withE0119:This is an ecosystem-wide break tracked upstream in time-rs/time#783. The maintainer has acknowledged it and a patch is pending.
For lance it takes down every Rust and Python build job.
mainhas been red since the first CI run after the upstream release, with no code change in between: CI re-resolved the newly publishedtimeat build time, and thesubsequent beta release baked
0.3.48into the committed lockfiles. It blocks all open PRs, not just one (#7254 rebases on top once this lands).Change
Pin
timeto the last good release,0.3.47, viacargo update -p time --precise 0.3.47(the workaround recommended in time-rs/time#783). Applied to both lockfiles:Cargo.lock(root workspace)python/Cargo.lock(thepython/crate is excluded from the root workspaceand carries its own lock, so the Python wheel and lint jobs need the pin too)
Lockfile only, no manifest or source change. Downgrades
time(0.3.48 to 0.3.47),time-core, andtime-macros. Nothing requires>= 0.3.48(it is hours old), so the pin is safe.Test plan
cargo check -p aws-smithy-types --lockedcompiles clean in both the root andpython/workspaces (wasE0119).Note on build-no-lock
build-no-lockstays red by design and is non-blocking. It removesCargo.lockand re-resolves against the latest crates, so it re-pulls the brokentime 0.3.48regardless of this pin. It is the canary for exactly thiskind of upstream break, and
maincurrently merges with it red (#7234 merged today with it failing).Follow-up
Remove the pin once upstream resolves the conflict, tracked in time-rs/time#783:
time 0.3.49), bump to it, or0.3.48is yanked (requested in the issue), in which case a fresh resolve returns to0.3.47on its own andbuild-no-lockself-heals.