fix(python): use non-deprecated params in search benchmark fixtures#7285
Open
sezruby wants to merge 1 commit into
Open
fix(python): use non-deprecated params in search benchmark fixtures#7285sezruby wants to merge 1 commit into
sezruby wants to merge 1 commit into
Conversation
The search benchmark dataset fixtures pass `use_legacy_format=False` and `index_cache_size=...` to `write_dataset` / `lance.dataset`, both of which are deprecated. Because the test config sets `filterwarnings = error::DeprecationWarning`, fixture setup raised `DeprecationWarning` and every benchmark in `test_search.py` errored out before running. Switch to the current parameters (`data_storage_version="stable"` and `index_cache_size_bytes`), restoring the benchmark suite. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dataset fixtures in
python/benchmarks/test_search.pypass deprecated parameters to the dataset APIs:lance.write_dataset(..., use_legacy_format=False)lance.dataset(..., index_cache_size=64 * 1024)The test config sets
filterwarnings = ['error::DeprecationWarning', ...], so these emitDeprecationWarningas errors during fixture setup. As a result every benchmark intest_search.pyerrors out before running:Fix
Switch to the current parameters:
use_legacy_format=False→data_storage_version="stable"(the exact mapping the deprecation shim applies).index_cache_size=64 * 1024→index_cache_size_bytes=512 * 1024 * 1024(512 MiB comfortably caches these 100k-row IVF_PQ indices).Verification
ruff check/ruff format --checkclean.