Skip to content

fix(storage): report AWS credential failures as I/O - #8406

Merged
Xuanwo merged 1 commit into
mainfrom
gatekeeper/fix-2466-1
Aug 8, 2026
Merged

fix(storage): report AWS credential failures as I/O#8406
Xuanwo merged 1 commit into
mainfrom
gatekeeper/fix-2466-1

Conversation

@lance-gatefixer

Copy link
Copy Markdown
Contributor

Root cause

AwsCredentialAdapter classified failures from the external AWS credential provider chain as Lance internal errors. In managed environments such as AWS Glue, a missing or unreachable credential source therefore produced the misleading internal-bug wrapper shown in the issue instead of an actionable I/O/configuration-path failure.

Fix

  • Classify AWS credential resolution failures as I/O errors while retaining the detailed provider diagnostic.
  • Add a regression test that injects a failed credential provider and verifies the I/O variant, nested cause, and absence of the internal-bug message.

Validation

  • cargo fmt --all
  • cargo clippy --all --tests --benches -- -D warnings
  • cargo test -p lance-io test_aws_credential_failure_is_io_error
  • cargo test -p lance-io -- --skip uring::tests (197 unit tests and doctests passed)

A full cargo test -p lance-io was also attempted; unrelated Linux io_uring cases failed or hung in this container, so the passing package run excluded that module.

Fixes #2466

@github-actions github-actions Bot added A-encoding Encoding, IO, file reader/writer bug Something isn't working labels Aug 7, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate recommendation: approve.

The change corrects the error category at the AWS credential-adapter boundary while preserving the provider diagnostic. The injected-provider regression test covers the propagated object-store error and confirms it no longer presents an external credential failure as an internal Lance defect.

@Xuanwo
Xuanwo merged commit c3056a5 into main Aug 8, 2026
40 checks passed
@Xuanwo
Xuanwo deleted the gatekeeper/fix-2466-1 branch August 8, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-encoding Encoding, IO, file reader/writer bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to get AWS credentials: an error occurred while loading credentials

1 participant