test(index): cover no-op optimize after compaction - #8408
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
test(index): cover no-op optimize after compaction#8408lance-gatefixer[bot] wants to merge 1 commit into
lance-gatefixer[bot] wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The change extends the existing no-op regression through index-segment consolidation and an actual fragment compaction while preserving both dataset-version and full file-set invariants. Reusing the existing all-index test keeps this coverage focused on the Python end-to-end contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optimize_indicesno-op regression through index-segment consolidation and file compactionRoot cause and fix
The original defect rebuilt steady-state index groups even when no fragments were unindexed, creating a new index UUID directory and manifest version on every call. The production no-op checks are already present on
main; this change closes the remaining regression-coverage gap for the issue's reported compact-then-reoptimize sequence so future compaction or index-remap changes cannot silently restore the disk churn.Validation
make builduv run pytest python/tests/test_optimize.py::test_optimize_indices_second_call_is_noopuv run make formatuv run make lint(passes; Pyright reports 10 existing missing-stub warnings)Fixes #6659