Improve some HDF5 error handling

[adamdempsey90]

PR Summary

This hardens how the spiner EOS reads the hdf5 files, e.g., check the file exists, check groups exist, etc.

This could also be applied in Spiner when the databox reads from the file.

Partially address #592

PR Checklist

• Adds a test for any bugs fixed. Adds tests for new features.
• Format your changes by using the make format command after configuring with cmake.
• Document any new features, update documentation for changes made.
• Make sure the copyright notice on any files you modified is up to date.
• After creating a pull request, note it in the CHANGELOG.md file.
• LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

• Update the version in cmake.
• Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
• Maintainers: ensure spackages are up to date:
  • LANL-internal team, update XCAP spackages
  • Current maintainer of upstream spackages, submit MR to spack

[Yurlungur]

Good improvement. Will need to add a changelog and for tests to pass.

[Yurlungur]

we might want to move these to spiner instead of singularity-eos. But they're fine here for now.

[adamdempsey90]

I debated doing that, but convinced myself that singularity could use hdf5 irrespective of spiner. Maybe that's a philosophical distinction and not a real one in practice

[Yurlungur]

No that's a fair point... I was just thinking of code reuse. We can leave it here for now.

[Yurlungur]

@adamdempsey90 did tests pass on re-git? If so, I think this is good to go.

[adamdempsey90]

@adamdempsey90 did tests pass on re-git? If so, I think this is good to go.

They did not. Still investigating.

[adamdempsey90]

@adamdempsey90 did tests pass on re-git? If so, I think this is good to go.

They did not. Still investigating.

The issue was checking for the attributes in the wrong group. The check before trying to access an attribute is redundant, though. Now I just check the return status.

Tests pass now.