Skip to content

feat: LDContext is java.io.Serializable #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshfriend wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

feat: LDContext is java.io.Serializable #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/shared/common/src/main/java/com/launchdarkly/sdk/ArrayBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.launchdarkly.sdk;

import java.io.Serializable;
import java.util.ArrayList;
import java.util.List;

Expand All @@ -8,7 +9,7 @@
* <p>
* Builder methods are not thread-safe.
*/
public final class ArrayBuilder {
public final class ArrayBuilder implements Serializable {
Copy link
Contributor

@tanderson-ld tanderson-ld Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a little weird to me to make a builder serializable. Do you know which structure is leading the default serialization here? I don't see the dependency from LDContext to here.

Copy link
Contributor

@tanderson-ld tanderson-ld Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the ArrayBuilder in LDValue?

private List<LDValue> builder = new ArrayList<>();
private volatile boolean copyOnWrite = false;

Expand Down
3 changes: 2 additions & 1 deletion lib/shared/common/src/main/java/com/launchdarkly/sdk/AttributeMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
package com.launchdarkly.sdk;

import java.io.Serializable;
import java.util.HashMap;
import java.util.Map;

final class AttributeMap {
final class AttributeMap implements Serializable {
private final AttributeMap parent;
private final Map<String, LDValue> map;

Expand Down
4 changes: 3 additions & 1 deletion lib/shared/common/src/main/java/com/launchdarkly/sdk/json/JsonSerializable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
package com.launchdarkly.sdk.json;

import java.io.Serializable;

/**
* Marker interface for SDK classes that have a custom JSON serialization.
*
* @see JsonSerialization
* @see LDGson
*/
public interface JsonSerializable {
public interface JsonSerializable extends Serializable {
}
Loading