ci: fixing electron ci breaking#1395
Merged
Merged
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
|
@launchdarkly/browser size report |
joker23
force-pushed
the
skz/fix-electron-run
branch
from
320fd3f to
f48bc8f
Compare
tanderson-ld
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
CI-only Node version pin with no application or security logic changes.
Overview
Pins Node.js to 24.15 in the Electron GitHub Actions workflow (
build-test-electronmatrix andrun-example) instead of floating 24 / latest 24.x.Comments document that Node 24.16 introduces breaking changes that break Electron installation in CI, with a note to revisit once upstream fixes land.
Reviewed by Cursor Bugbot for commit f48bc8f. Bugbot is set up for automated code reviews on this repo. Configure here.